FriendsOfBehat / SymfonyExtension

:musical_score: Extension integrating Behat with Symfony.
MIT License
472 stars 62 forks source link

Switch back to the original `behat/mink-browserkit-driver` #195

Closed mpdude closed 8 months ago

mpdude commented 1 year ago

This builds upon the suggestion in #187.

If I get it right, friends-of-behat/mink-browserkit-driver was a fork of the original behat/mink-browserkit-driver at a time where the original repo was lagging behind in terms of PHP and Symfony version support.

It seems the original is now being maintained again, so we should recommend switching back – especially since the FriendsOfBehat version says:

No updates other than Symfony compatibility will be provided, but this fork might be synchronised with the original repository in the future.

SymfonyHackday

mpdude commented 1 year ago

@stof your 👀 and opinion would be very much appreciated.

Regarding Psalm errors, I think the root cause is a pending docblock – see https://github.com/minkphp/MinkBrowserKitDriver/pull/166.

We probably need that fixed and released before we can continue here.

mpdude commented 1 year ago

~What about https://github.com/FriendsOfBehat/MinkExtension vs. https://github.com/Behat/MinkExtension, is that also something we /(sh|c)ould/ switch back?~ No, Behat/MinkExtension seems to be abandoned. https://github.com/Behat/MinkExtension/issues/370.

mpdude commented 1 year ago

Converted to draft to prevent accidental merges until necessary changes have been merged elsewhere.

stof commented 1 year ago

for the Behat MinkExtension, the goal is indeed for the FriendsOfBehat one to be the replacement. But switching back is the way to go for Mink drivers (btw, if you want to help maintaining Mink, we could welcome new maintainers there instead of forking drivers)

stof commented 1 year ago

@mpdude any chance to finish this work ?

lchrusciel commented 8 months ago

Thanks @mpdude and @stof for cooperation! :tada: