search

FriendsOfBehat / SymfonyExtension

:musical_score: Extension integrating Behat with Symfony.
MIT License
472 stars 62 forks source link

Update dependencies #199

Closed Jeroeny closed 7 months ago

Jeroeny commented 1 year ago

symfony/proxy-manager-bridge doesn't seem to be used, and is blocking upgrade to PHP 8.2. Also it's deprecated: https://github.com/symfony/symfony/pull/48484

mpdude commented 1 year ago

Symfony 4.4 is not completely unsupported yet, they still have security fixes.

Is it really necessary to drop compatibility with older versions of packages, as long as we don't gain anything from it? I mean we don't have to do any extra work at the moment to keep it supported, right?

Jeroeny commented 1 year ago

@mpdude Fair enough, undid that change.

pamil commented 1 year ago

I haven't worked on this extension for a while, but symfony/proxy-manager-bridge was required in the first place because Symfony failed silently to create lazy services if it's not present. There's a conditional in their code to check for its existence and I think it was a lazy Mink driver session that required it to be a lazy service indeed. We might need a test case for it though.