FriendsOfBehat / SymfonyExtension

:musical_score: Extension integrating Behat with Symfony.
MIT License
472 stars 62 forks source link

Support Symfony 7 #203

Closed Jeroeny closed 7 months ago

Jeroeny commented 9 months ago

Add support for Symfony 7. It seems no changes were necessary. The Client alias could be removed because it only existed in Symfony 4.x

Chris53897 commented 9 months ago

I think 5.3 || ^6.0 || ^7.0 should be changed to 5.4 || ^6.0 || ^7.0. As only 5.4 has LTS

damien-louis commented 8 months ago

Symfony 7 was released today https://symfony.com/blog/symfony-7-0-0-released

damien-louis commented 8 months ago

@Yozhef: this PR seems ready to be merged?

Chris53897 commented 8 months ago

The first step is to approve the ci run and check results.

damien-louis commented 8 months ago

Sure, but I guess only mainteners can run CI

tacman commented 8 months ago

5.4 || ^6.0 || ^7.0.

Actually, 6.0-6.2 aren't supported either. I think it should be

5.4 || ^6.3 || ^7.0

Yozhef commented 8 months ago

@Jeroeny you can leave version 4.4 - in order not to issue a major release that will require major changes

tacman commented 8 months ago

I think @Jeroeny means "drop" 4.4 (not leave as in "leave it in", but leave as it drop it).

Jeroeny commented 8 months ago

@Yozhef so should it become ^4.4 || ^5.4 || ^6.4 || ^7.0"?

Yozhef commented 8 months ago

@Jeroeny yes, if remove 4.4 we need create a new major release. But at the moment I don't see a great need for it

Chris53897 commented 8 months ago

Why do you need a new major version for drop support of an unsupported Symfony version?

tacman commented 8 months ago

But at the moment I don't see a great need for it

I think the issue is that if supporting an unsupported version of Symfony is keeping it from supporting the current version of Symfony, the preference should be to support the release version and not the old version.

Jeroeny commented 8 months ago

I also don't think it'd need a major release, because composer would prevent the minor update anyway if you're still on Symfony 4.4. But I will readd ^4.4, since this is not up to me :).

loic425 commented 8 months ago

@pamil Could you help us with this one too please?

Yozhef commented 7 months ago

This pr - add only composer but need add ci see https://github.com/FriendsOfBehat/SymfonyExtension/pull/205/files