search

FriendsOfCake / app-template

CakePHP2: An empty application template, for use with composer
71 stars 16 forks source link

Load CakePHP from packagist instead of PEAR #45

Closed Phally closed 10 years ago

Phally commented 10 years ago

Let's try this again.

Refs #31. Refs 4aa4295f03dfedce4d02388453af5c71d13a9b57.

Seems to be working pretty well, although I have only a small app to test with. The only problem I had was a missing CakeLog error. So I added the App::uses() in core.php.

It makes sense though. CakeLog used to be loaded in bootstrap.php and that's where the original repo also has the CakeLog config. That was moved to core.php without the App::uses() call. I think previously composer accidentally loaded it somehow, but I'm not sure.

@ADmad, what errors did you get and do you still see those errors with these changes?

ADmad commented 10 years ago

Duplicate class name errors, i would presume the errors would still occur since the lib contains app skeleton with same classes that would be present in your app.

ADmad commented 10 years ago

I see in my revert commit is mentioned included tests as the issue. I don't remember the exact error but considering the core folder structure is the same same error should appear. That's the reason test cases have been explicitly removed from the PEAR package.

Phally commented 10 years ago

Hmm didn't see those. Also ran the core tests and worked fine.

ADmad commented 10 years ago

cakephp/cakephp#2620

Phally commented 10 years ago

Ok, seems like there has been a fair amount of research gone into that. We'll just keep it like this to be sure everything works.