Closed ADmad closed 2 years ago
@ndm2 What do you propose we do about the "prefer-lowest" job? It's not practical to have a separate set of expectations for Cake < 4.3 due to the addition of ARIA attributes. I don't want to update the core constraints in composer since the code actually works fine for lower versions of 4.x.
I'd say we inject the two attributes manually if they're not present. I did that for the BS5 version (aria-describedby
can be omitted):
Codecov Report
100.00% <ø> (ø)
99.20% <100.00%> (-0.04%)
96.00% <0.00%> (-0.62%)
98.46% <0.00%> (-0.04%)
100.00% <0.00%> (ø)
100.00% <0.00%> (ø)
100.00% <0.00%> (ø)
100.00% <0.00%> (ø)
Continue to review full report at Codecov.