FriendsOfCake / bootstrap-ui

CakePHP: Transparently use Bootstrap
MIT License
340 stars 146 forks source link

Update tests. #361

Closed ADmad closed 2 years ago

codecov[bot] commented 2 years ago

Codecov Report

Merging #361 (15755de) into master (7dcf728) will decrease coverage by 0.05%. The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #361      +/-   ##
============================================
- Coverage     99.25%   99.19%   -0.06%     
- Complexity      329      335       +6     
============================================
  Files            21       20       -1     
  Lines           934      869      -65     
============================================
- Hits            927      862      -65     
  Misses            7        7              
Impacted Files Coverage Δ
src/View/Helper/FlashHelper.php 100.00% <ø> (ø)
src/View/Helper/FormHelper.php 99.20% <100.00%> (-0.04%) :arrow_down:
src/View/Widget/InputgroupTrait.php 96.00% <0.00%> (-0.62%) :arrow_down:
src/Command/InstallCommand.php 98.46% <0.00%> (-0.04%) :arrow_down:
src/View/UIViewTrait.php 100.00% <0.00%> (ø)
src/View/Helper/HtmlHelper.php 100.00% <0.00%> (ø)
src/View/Widget/FileWidget.php 100.00% <0.00%> (ø)
src/Command/BootstrapCommand.php 100.00% <0.00%> (ø)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 7dcf728...15755de. Read the comment docs.

ADmad commented 2 years ago

@ndm2 What do you propose we do about the "prefer-lowest" job? It's not practical to have a separate set of expectations for Cake < 4.3 due to the addition of ARIA attributes. I don't want to update the core constraints in composer since the code actually works fine for lower versions of 4.x.

ndm2 commented 2 years ago

I'd say we inject the two attributes manually if they're not present. I did that for the BS5 version (aria-describedby can be omitted):

https://github.com/FriendsOfCake/bootstrap-ui/blob/eb70a72c66dc0e722efd1e7f28a8f69399123711/src/View/Helper/FormHelper.php#L917-L982