search

FriendsOfCake / cakephp-csvview

CakePHP: A view class for generating CSV
MIT License
176 stars 64 forks source link

fix bom appears in all rows if _bom is enabled. #101 #102

Closed holywise closed 5 years ago

holywise commented 5 years ago
codecov[bot] commented 5 years ago

Codecov Report

Merging #102 into master will increase coverage by 0.02%. The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #102      +/-   ##
============================================
+ Coverage     98.51%   98.54%   +0.02%     
- Complexity       55       56       +1     
============================================
  Files             1        1              
  Lines           135      137       +2     
============================================
+ Hits            133      135       +2     
  Misses            2        2
Impacted Files Coverage Δ Complexity Δ
src/View/CsvView.php 98.54% <100%> (+0.02%) 56 <0> (+1) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update fa3729e...b4cff01. Read the comment docs.

dereuromark commented 5 years ago

Looks good to me!