search

FriendsOfCake / cakephp-csvview

CakePHP: A view class for generating CSV
MIT License
176 stars 64 forks source link

Fix type hinting in README #110

Closed tai-sho closed 5 years ago

tai-sho commented 5 years ago

Currently, it seems that Entity is not passed to function. I modified type hinting described in README to array.

https://github.com/FriendsOfCake/cakephp-csvview/blob/3.3.2/src/View/CsvView.php#L332

codecov[bot] commented 5 years ago

Codecov Report

Merging #110 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #110   +/-   ##
=========================================
  Coverage     98.54%   98.54%           
  Complexity       56       56           
=========================================
  Files             1        1           
  Lines           137      137           
=========================================
  Hits            135      135           
  Misses            2        2

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update cc62c59...4732339. Read the comment docs.