search

FriendsOfCake / cakephp-csvview

CakePHP: A view class for generating CSV
MIT License
176 stars 64 forks source link

Use view options/config instead of special view vars. #111

Closed ADmad closed 5 years ago

codecov[bot] commented 5 years ago

Codecov Report

Merging #111 into cake-4.x will decrease coverage by 0.21%. The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             cake-4.x   #111      +/-   ##
============================================
- Coverage       99.22%    99%   -0.22%     
+ Complexity         57     41      -16     
============================================
  Files               1      1              
  Lines             129    101      -28     
============================================
- Hits              128    100      -28     
  Misses              1      1
Impacted Files Coverage Δ Complexity Δ
src/View/CsvView.php 99% <100%> (-0.22%) 41 <0> (-16)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f1d74f4...0d7d075. Read the comment docs.

josegonzalez commented 5 years ago

This breaks BC, right?

ADmad commented 5 years ago

Yes it does. Using the special view var _serialize will throw notice in 4.0. So people have to update that, so might as well update other CsvView specific options too.

josegonzalez commented 5 years ago

Okay so this is specifically for 4.0 or are we bumping major and saying its compatible with 3.x and 4.x?

ADmad commented 5 years ago

This is specifically for 4.0 compatibility. It's not feasible to have a version which would be compatible with both Cake 3 and 4.

ADmad commented 5 years ago

In case you missed it the PR is targeted to the cake-4.x branch I had created earlier for Cake 4 compatibility. We can merge it to master and make a new major release once Cake 4.0 is released.