search

FriendsOfCake / cakephp-csvview

CakePHP: A view class for generating CSV
MIT License
176 stars 64 forks source link

Update README.md #123

Closed gludie closed 4 years ago

gludie commented 4 years ago

I had minor issue to follow the standard instructions for composer - looks like 3.4 is default ?

codecov[bot] commented 4 years ago

Codecov Report

Merging #123 into master will not change coverage by %. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #123   +/-   ##
=========================================
  Coverage     98.56%   98.56%           
  Complexity       57       57           
=========================================
  Files             1        1           
  Lines           139      139           
=========================================
  Hits            137      137           
  Misses            2        2

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c3890f6...611e90b. Read the comment docs.

dereuromark commented 4 years ago

Shouldnt this rather go into https://github.com/FriendsOfCake/cakephp-csvview/tree/cake-4.x ?

gludie commented 4 years ago

yes, you are right, sorry for wrong pull request on default branch - may be worth only a hint at default (that for cake4 another branch is already available ;-) ) ... should I do another pull request for cake-4.0 branch ?

gludie commented 4 years ago

can be closed here