search

FriendsOfCake / cakephp-upload

CakePHP: Handle file uploading sans ridiculous automagic
https://cakephp-upload.readthedocs.io/
MIT License
551 stars 255 forks source link

Filesystem visibility option #436

Closed jorisvaesen closed 7 years ago

jorisvaesen commented 7 years ago

Option to set file either public or private.

josegonzalez commented 7 years ago

Needs tests.

jorisvaesen commented 7 years ago

I know, but phpunit isn't working in my Ubuntu VM for the moment.

jorisvaesen commented 7 years ago

Travis doesn't get triggered?

ypnos-web commented 7 years ago

I like the idea to explicitely expose this parameter, just a note that setting this is already possible via: 'filesystem' => ['options' => ['visibility' => null]]

josegonzalez commented 7 years ago

Oh actually thats probably the better change, to just show how to do that in the docs @ypnos-web .

jorisvaesen commented 7 years ago

Wow, missed that option completely. Is indeed the better change.