search

FriendsOfCake / cakephp-upload

CakePHP: Handle file uploading sans ridiculous automagic
https://cakephp-upload.readthedocs.io/
MIT License
551 stars 255 forks source link

incompatible with versions above 3.4. * #492

Closed rederlo closed 6 years ago

rederlo commented 6 years ago

Call to undefined method Cake\Database\Schema\TableSchema::setColumnType()

saeideng commented 6 years ago

this method added since cake 3.5.0

mentisy commented 5 years ago

The cakephp/cakephp~3.4 constraint means it will upgrade up to (not including) 4.0, right? As of now, the latest version is 3.7.3, which means when I fork this repository, that is the version it will install when running composer install.

When I then run tests in phpunit without altering any code in the cakephp-upload repository, I will get an error as changes in the CakePHP core has occured. If I change composer to cakephp/cakephp:3.6, I get no such error and all tests pass.

The error I encounter is: Uncaught InvalidArgumentException: Cannot convert value of typestringto integer in X:\xampp\htdocs\cakephp-upload\vendor\cakephp\cakephp\src\Database\Type\IntegerType.php:64

I'm not well versed in this yet, so let me know if I'm not thinking correctly.

davidyell commented 5 years ago

https://semver.mwl.be/#?package=cakephp%2Fcakephp&version=~3.4&minimum-stability=stable

So as you can see the constraint means 3.4.0 to any version above, but not a 4.x release. Perhaps the minimum constraint can be increased now? Any thoughts @josegonzalez

ADmad commented 5 years ago

@mentisy Mostly likely the plugin's test suite wasn't run after CakePHP 3.7 was released and needs some fix to account for changes in 3.7.

You are welcome to submit a fix for the issue.