search

FriendsOfCake / cakephp-upload

CakePHP: Handle file uploading sans ridiculous automagic
https://cakephp-upload.readthedocs.io/
MIT License
551 stars 255 forks source link

Updating tests to pass with CakePHP 3.7.3 #502

Closed mentisy closed 5 years ago

mentisy commented 5 years ago

When running tests, these errors and warnings occurred:

  1. Plugin::load() is deprecated. Use Application::addPlugin() instead. This method will be removed in 4.0.0.

  2. Uncaught InvalidArgumentException: Cannot convert value of type string to integer in cakephp-upload/vendor/cakephp/cakephp/src/Database/Type/IntegerType.php:64

Fixed by:

  1. Changed how the plugin is added in tests.
  2. Changed test fixture filename field from integer to string.
mentisy commented 5 years ago

Should the phpDoc be removed from Plugin.php?

mentisy commented 5 years ago

Seems like the Travis CI build failed to download or install PHP 7.2 to run the build.

Before creating this pull request, the build was run successfully on my fork: https://travis-ci.org/mentisy/cakephp-upload/builds/487029477

Unsure how to go from here.

Seems like the file it attempted to download is valid, as I could download it when pasting it to a browser. Can we retry the build?

burzum commented 5 years ago

@ADmad @josegonzalez can we get this merged?