search

FriendsOfCake / cakephp-upload

CakePHP: Handle file uploading sans ridiculous automagic
https://cakephp-upload.readthedocs.io/
MIT License
551 stars 255 forks source link

Cake 4.x UploadedFile Fixes #524

Closed commercial-hippie closed 4 years ago

commercial-hippie commented 5 years ago

Cake 4 uses the \Zend\Diactoros\UploadedFile class for uploaded files which broke the plugin. Might be better to use the UploadedFileInterface here though.

Will look at tests soon just wanted to make the pull request because I keep on forgetting about it and did this quite some time ago.

dereuromark commented 4 years ago

Why wasnt the namespace fixed for the new major? Josegonzalez/Upload is still the name unfortunately.

josegonzalez commented 4 years ago

I would be fine with changing the namespace.

dereuromark commented 4 years ago

I think it is too late after releasing several stable releases/patches. It is just confusing to have FOC/Upload etc mentioned, and then the namespace and plugin name being a different one.

dereuromark commented 4 years ago

I fixed it here for now: https://github.com/FriendsOfCake/awesome-cakephp#files

josegonzalez commented 4 years ago

@ADmad I fixed the review comment, anything else before this can get merged?

Given that we have other bc-incompatible changes, I'd also be fine with a major release that changes the namespace (or even drops the top-level namespace to match how we do all the other FOC plugins).

ADmad commented 4 years ago

@josegonzalez Well the test cases are failing, so the change done to handle UploadedFileInterface still needs work.

gersonfs commented 4 years ago

Hello! Is anyone working on correcting the tests?