FriendsOfCake / cakephp-upload

CakePHP: Handle file uploading sans ridiculous automagic
https://cakephp-upload.readthedocs.io/
MIT License
551 stars 255 forks source link

Fix beforeMarshall if file uploads are array #590

Closed TerryKern closed 1 year ago

TerryKern commented 1 year ago

These are the changes form https://github.com/FriendsOfCake/cakephp-upload/pull/588 with my PHP 7.2 compatitbily suggestion applied to it.

This should allow all checks to pass.

codecov[bot] commented 1 year ago

Codecov Report

Base: 95.68% // Head: 95.50% // Decreases project coverage by -0.17% :warning:

Coverage data is based on head (9275590) compared to base (878cba2). Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #590 +/- ## ============================================ - Coverage 95.68% 95.50% -0.18% - Complexity 108 109 +1 ============================================ Files 11 11 Lines 278 267 -11 ============================================ - Hits 266 255 -11 Misses 12 12 ``` | [Impacted Files](https://codecov.io/gh/FriendsOfCake/cakephp-upload/pull/590?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FriendsOfCake) | Coverage Δ | | |---|---|---| | [src/Model/Behavior/UploadBehavior.php](https://codecov.io/gh/FriendsOfCake/cakephp-upload/pull/590/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FriendsOfCake#diff-c3JjL01vZGVsL0JlaGF2aW9yL1VwbG9hZEJlaGF2aW9yLnBocA==) | `94.56% <100.00%> (-0.18%)` | :arrow_down: | | [src/File/Writer/DefaultWriter.php](https://codecov.io/gh/FriendsOfCake/cakephp-upload/pull/590/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FriendsOfCake#diff-c3JjL0ZpbGUvV3JpdGVyL0RlZmF1bHRXcml0ZXIucGhw) | `100.00% <0.00%> (ø)` | | | [src/File/Path/DefaultProcessor.php](https://codecov.io/gh/FriendsOfCake/cakephp-upload/pull/590/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FriendsOfCake#diff-c3JjL0ZpbGUvUGF0aC9EZWZhdWx0UHJvY2Vzc29yLnBocA==) | `100.00% <0.00%> (ø)` | | | [src/File/Path/Basepath/DefaultTrait.php](https://codecov.io/gh/FriendsOfCake/cakephp-upload/pull/590/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FriendsOfCake#diff-c3JjL0ZpbGUvUGF0aC9CYXNlcGF0aC9EZWZhdWx0VHJhaXQucGhw) | `100.00% <0.00%> (ø)` | | | [src/File/Transformer/DefaultTransformer.php](https://codecov.io/gh/FriendsOfCake/cakephp-upload/pull/590/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FriendsOfCake#diff-c3JjL0ZpbGUvVHJhbnNmb3JtZXIvRGVmYXVsdFRyYW5zZm9ybWVyLnBocA==) | `100.00% <0.00%> (ø)` | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FriendsOfCake). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FriendsOfCake)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.