FriendsOfCake / crud-json-api

Build advanced JSON API Servers with almost no code.
https://crud-json-api.readthedocs.io/
MIT License
56 stars 32 forks source link

array_key_exists is deprecated #150

Closed geoidesic closed 2 years ago

geoidesic commented 3 years ago

JsonApiListener uses this deprecated method, which will throw errors / warnings.

dakota commented 3 years ago

As far as I can tell array_key_exists isn't deprecated? Do you have a link to where the deprecation is documented?

geoidesic commented 3 years ago

https://www.php.net/manual/en/migration74.deprecated.php

Looks like it is not completely deprecated, only for use with objects. Maybe not a necessary change then?

However, the reason I made this PR was because I was seeing the warnings pop up when using JsonApiListener with PHP 7.4

ADmad commented 2 years ago

The testsuite is now run for up to PHP 8.1 as part of CI and there are no warnings reported.