search

FriendsOfDoctrine / dbal-clickhouse

Doctrine DBAL driver for ClickHouse database
GNU General Public License v3.0
98 stars 80 forks source link

Added Doctrine DBAL 3 support #54

Closed ihortymoshenko closed 10 months ago

ihortymoshenko commented 1 year ago

Hello!

I added support for Doctrine DBAL 3 and leave support only for PHP 8 in this pull request.

I propose to merge these changes to master and make a new major version.

If you have any questions, let's discuss

tarjei commented 1 year ago

Any chance this gets merged?

bakl commented 1 year ago

Any chance this gets merged?

+++

lionser commented 1 year ago

It is a good chnages, i will wait for marge it. Thanks.

russelomua commented 1 year ago

I think better leave compatibility with php 7 and dbal ^2.13. Good if your project is progressive and used a cutting edge technologies, but library must corers to most of users. p.s. i use an php 8.1 and want to update project to dbal ^3

ihortymoshenko commented 1 year ago

@russelomua,

the latest version of this bundle supports PHP 7 and Doctrine DBAL 2, so users should have no issues.

PHP 7 is no longer supported (https://www.php.net/supported-versions.php). There aren't even any security fixes.

We should go ahead and start using PHP 8 and Doctrine DBAL 3

russelomua commented 1 year ago

Yep, you totally right, in perfect world it is. But in reality we still have a lot of projects running by php7+ even 5.6 :) My point in if you cud leave support - leave it. Lib owners?

ihortymoshenko commented 1 year ago

@russelomua,

you can continue to use this bundle with PHP 7 & Doctrine DBAL 2, this PR is about something else

Nicc0 commented 1 year ago

It is a good chnages, i will wait for marge it. Thanks.

What about it?

amadeuszxd commented 1 year ago

What about it?

+++

russelomua commented 1 year ago

Maintainers, please. It's time :)

asanikovich commented 1 year ago

We will take it in about 2 weeks.

russelomua commented 1 year ago

@ihortymoshenko, need to fix README.md because you rename ArrayStringType to ArrayStringableType

# app/config/config.yml
doctrine:
    dbal:
        connections:
        ...
        types:
            ...
            array(string): FOD\DBALClickHouse\Types\ArrayStringType
russelomua commented 12 months ago

We will take it in about 2 weeks.

any updates?

ihortymoshenko commented 11 months ago

@ihortymoshenko, need to fix README.md because you rename ArrayStringType to ArrayStringableType

# app/config/config.yml
doctrine:
    dbal:
        connections:
        ...
        types:
            ...
            array(string): FOD\DBALClickHouse\Types\ArrayStringType

Fixed

asanikovich commented 10 months ago

We made it. Thank you @ihortymoshenko

Version https://github.com/FriendsOfDoctrine/dbal-clickhouse/releases/tag/v2.0.0 ready for you.