FriendsOfFlarum / byobu

Well integrated, advanced private discussions for your Flarum forum.
https://discuss.flarum.org/d/4762-flagrow-by-bu-well-integrated-advanced-private-discussions
MIT License
54 stars 33 forks source link

Fix migrations #100

Closed clarkwinkelmann closed 4 years ago

clarkwinkelmann commented 4 years ago

First commit fixes an issue on rollback

Second commit fixes an issue when enabling the extension with notices visible.

@imorland was that undefined variable a copy-paste error or is there something else I should be aware of before merging.

POST http://beta12.flarum.localhost/api/extensions/fof-byobu

<br />
<b>Notice</b>:  Undefined variable: permissionKey in <b>/home/clark/Projects/flarum-beta12/vendor/fof/byobu/migrations/2020_02_19_110103_remove_retired_settings_key.php</b> on line <b>15</b><br />
<br />
<b>Notice</b>:  Undefined variable: permissionKey in <b>/home/clark/Projects/flarum-beta12/vendor/fof/byobu/migrations/2020_02_19_110103_remove_retired_settings_key.php</b> on line <b>23</b><br />
<br />
<b>Fatal error</b>:  Uncaught Laminas\HttpHandlerRunner\Exception\EmitterException: Output has been emitted previously; cannot emit response in /home/clark/Projects/flarum-beta12/vendor/laminas/laminas-httphandlerrunner/src/Exception/EmitterException.php:24