Feature request / bug report: Disallowing public dicussions in tags dedicated to private discussions

[pflstr]

At the moment it's not possible to disallow public discussions in tags that are dedicated to private discussions:

https://discuss.flarum.org/d/4762-friendsofflarum-by-bu-well-integrated-advanced-private-discussions/514

One might think of the following settings:

• Start discussions: Only Admins
• Create private discussions with users / groups: Registered Users

... but this doesn't solve the problem. To start a private discussion one needs both of the above mentioned permissions, the settings Create private discussions with users and Create private discussions with groups can only restrict the Start discussions permission, they can not extend them.

To solve the problem one would have to find a way to extend the Start discussions permission. One might change the permission check from:

if (user_allowed_to_start_discussion) {...}

to:

if (user_allowed_to_start_discussion or (discussion_is_private and user_allowed_to_create_private_discussion)) {...}

Another possible explanation: Maybe this issue is related to https://github.com/FriendsOfFlarum/byobu/issues/39.

[imorland]

Closing as tags are no longer a part of this extension