search

FriendsOfFlarum / byobu

Well integrated, advanced private discussions for your Flarum forum.
https://discuss.flarum.org/d/4762-flagrow-by-bu-well-integrated-advanced-private-discussions
MIT License
54 stars 33 forks source link

Replace t is undefined error with proper message if tag slug is invalid #105

Closed clarkwinkelmann closed 4 years ago

clarkwinkelmann commented 4 years ago

Fixes #104

clarkwinkelmann commented 4 years ago

Another option here would be instead of not setting any tag, I could set a random tag (first one from the store), which will then trigger the existing "Invalid tag for private discussions" error from the backend, instead of the "minimum 1 tag required" error from the Tags extension.

clarkwinkelmann commented 4 years ago

@imorland should I tag a new release or did you want to do it ?

imorland commented 4 years ago

@clarkwinkelmann can you hold on for a moment please? I'm just investigating a report of notifications not firing in 0.4.4

If it needs a fix, it would make sense to wrap it all together for a new tag - if that's ok with you?

clarkwinkelmann commented 4 years ago

@imorland works for me. I'll let you take care of it.

I just wanted to make sure it's not being forgotten after I saw the merge notification.