search

FriendsOfFlarum / byobu

Well integrated, advanced private discussions for your Flarum forum.
https://discuss.flarum.org/d/4762-flagrow-by-bu-well-integrated-advanced-private-discussions
MIT License
54 stars 33 forks source link

Prevent collapse of new PD button on mobile (#116) #118

Closed davwheat closed 4 years ago

davwheat commented 4 years ago

Removing the App-primaryControl class from the button fixes this issue, saving a hell of a lot of overrides in CSS, and not really affecting anything else.

Custom themes might have issues with this, as the button won't have a possibly overridden class, so style changes will need to be added manually.

Would overriding all the styles which make it collapse be better?

(Haven't built dist JS.)

imorland commented 4 years ago

Perhaps the solution here would be to add a byobu-specific class that custom themes could make use of, if they need to?

davwheat commented 4 years ago

Yep! This button already has .item-start_private added to it. Is this enough, or should we go the full mile and add something like fof-byobu_primaryControl, for example?

davwheat commented 4 years ago

Actually, looking at some themes, most choose to override .Button--primary in this case, so App-primaryControl might not be an issue.

imorland commented 4 years ago

I feel that fof-byobu_primaryControl could potentially make 3rd party theming easier in this case, so I would be inclined to include it

davwheat commented 4 years ago

Done!