FriendsOfFlarum / byobu

Well integrated, advanced private discussions for your Flarum forum.
https://discuss.flarum.org/d/4762-flagrow-by-bu-well-integrated-advanced-private-discussions
MIT License
54 stars 33 forks source link

Fix composer remaining open (minimised) when creating PD from user card #121

Closed davwheat closed 4 years ago

davwheat commented 4 years ago

Fixes #120

This is a super simple change which seems to fix the issue.

Moving the composer hide until after we've navigated to the new discussion makes the composer hide correctly.

Possibly some super weird and barely reproducible upstream bug?

ezgif com-video-to-gif

imorland commented 4 years ago

So simple it's almost embarrasing, thank you for this @davwheat

davwheat commented 4 years ago

@imorland it still doesn't make sense to me though... Surely this should break in both instances of creating a PD?

imorland commented 4 years ago

Checking this out now! 🕺

imorland commented 4 years ago

You're a 🌟 Thank you so much for this, I will merge now!