Closed davwheat closed 3 years ago
I think it's entirely possible that you forgot in your sleep deprived state to commit the file(s) that address Fix recipients modal styling issue
to this PR @davwheat
Oh god I did... 😅
I'm going to get back on this tonight when I get home from college -- sorry about the wait! 🙈
Cool, thanks @davwheat :)
Ping me if you need anything, I'll be around tonight
Also, this will become 1.0.0-beta.7
;)
Ok, I think it's ready for review now! Everything works (unless you find it doesn't of course :see_no_evil:)
Hey! Will https://github.com/FriendsOfFlarum/byobu/commit/2b5a11a3a8175d9abc081e30cc07080b4b8bd459 be added to 1.0.0-beta.7
also, as it resolves a little but important issue?
@Ornanovitch Cherry-picked that commit and made it a PR: #154
You rock thanks :sunglasses:
I've got a bunch of local changes to push that improve a11y and the first bullet, but it broke everything and it's 3am.
Changes proposed in this pull request:
.prettierrc
[deleted]
text instead of custom translationoninput
instead ofonkeyup
to support copy-pastingReviewers should focus on:
Screenshot
Confirmed
composer test
).Required changes: