FriendsOfFlarum / byobu

Well integrated, advanced private discussions for your Flarum forum.
https://discuss.flarum.org/d/4762-flagrow-by-bu-well-integrated-advanced-private-discussions
MIT License
54 stars 33 forks source link

Fixes/improvements for byobu beta 7 #153

Closed davwheat closed 3 years ago

davwheat commented 3 years ago

I've got a bunch of local changes to push that improve a11y and the first bullet, but it broke everything and it's 3am.

Changes proposed in this pull request:

Reviewers should focus on:

Screenshot

Confirmed

Required changes:

imorland commented 3 years ago

I think it's entirely possible that you forgot in your sleep deprived state to commit the file(s) that address Fix recipients modal styling issue to this PR @davwheat

davwheat commented 3 years ago

Oh god I did... 😅

davwheat commented 3 years ago

I'm going to get back on this tonight when I get home from college -- sorry about the wait! 🙈

imorland commented 3 years ago

Cool, thanks @davwheat :)

Ping me if you need anything, I'll be around tonight

imorland commented 3 years ago

Also, this will become 1.0.0-beta.7 ;)

davwheat commented 3 years ago

Ok, I think it's ready for review now! Everything works (unless you find it doesn't of course :see_no_evil:)

Ornanovitch commented 3 years ago

Hey! Will https://github.com/FriendsOfFlarum/byobu/commit/2b5a11a3a8175d9abc081e30cc07080b4b8bd459 be added to 1.0.0-beta.7 also, as it resolves a little but important issue?

davwheat commented 3 years ago

@Ornanovitch Cherry-picked that commit and made it a PR: #154

Ornanovitch commented 3 years ago

You rock thanks :sunglasses: