search

FriendsOfFlarum / byobu

Well integrated, advanced private discussions for your Flarum forum.
https://discuss.flarum.org/d/4762-flagrow-by-bu-well-integrated-advanced-private-discussions
MIT License
54 stars 33 forks source link

Removes edit recipient link on non-PD discussions #154

Closed davwheat closed 3 years ago

davwheat commented 3 years ago

This removes the edit recipient control on discussions that aren't private.

Cherry-picked from one of luceos's commits.

luceos commented 3 years ago

@imorland mentioned this is intentional. I think the better solution would be to rename the control label on Public discussions to "make private"

Ornanovitch commented 3 years ago

I fully agree, but IMO in that case such a possibility should depend on an other permission than editUserRecipients and editGroupRecipients as it's a very specific action that one could want to restrict a lot more :thinking:

Maybe it would be more consistent if edit{User|Group}Recipients were general permissions, when something like togglePrivateDiscussion would be a "restrict by tag" permission?