FriendsOfFlarum / byobu

Well integrated, advanced private discussions for your Flarum forum.
https://discuss.flarum.org/d/4762-flagrow-by-bu-well-integrated-advanced-private-discussions
MIT License
54 stars 33 forks source link

Support custom user sluggers and fix profile private discussions tab #164

Closed clarkwinkelmann closed 2 years ago

clarkwinkelmann commented 2 years ago

Changes proposed in this pull request: The main goal of this PR was to add support for custom user sluggers, in particular Flarum's built-in ID-based slugger, following this request https://discuss.flarum.org/d/4762-friendsofflarum-by-bu-well-integrated-advanced-private-discussions/1119

However in the process I also discovered that the private discussions profile tab just didn't seem to work anymore since v1.0 of Byobu, because the gambit it uses was removed. I have re-added the gambit and used a method from the existing trait to not duplicate any logic.

Reviewers should focus on:

I wasn't 100% sure what the page on the user profile was actually supposed to do. I guess it makes sense to list all private discussions we have with that particular user, without regard for whether they started the discussion or somebody else started it. But I'm not sure how it was done in 0.6, having never used the extension myself.

Confirmed

clarkwinkelmann commented 2 years ago

I think we do have the javascript build running on master? I purposefully not included the dist files in the PR, but I think it's all good on master now.