FriendsOfFlarum / byobu

Well integrated, advanced private discussions for your Flarum forum.
https://discuss.flarum.org/d/4762-flagrow-by-bu-well-integrated-advanced-private-discussions
MIT License
54 stars 33 forks source link

Added `recipientUsers` include for `CreateDiscussionController` #166

Closed iPurpl3x closed 3 years ago

iPurpl3x commented 3 years ago

Changes proposed in this pull request: Added recipientUsers include for CreateDiscussionController. This change has no direct effect on this extension but it fixed errors that other extensions could have because there is a discussion created in a custom way and the recipientUsers are not serialized, the following error might occur (see line of code):

TypeError: e.recipientUsers().find is not a function
    Pt Discussion.js:98

Reviewers should focus on: Nothing is broken and that this change doesn't impact performance

Confirmed

imorland commented 3 years ago

Thanks @iPurpl3x - this makes sense to include