FriendsOfFlarum / byobu

Well integrated, advanced private discussions for your Flarum forum.
https://discuss.flarum.org/d/4762-flagrow-by-bu-well-integrated-advanced-private-discussions
MIT License
54 stars 33 forks source link

Fix for #59 (Textbox width issue) #60

Closed ardacebi closed 5 years ago

ardacebi commented 6 years ago

Fixes the textbox width problem by adding a width section to RecipientsInput inside search.less set to 95%.

Fixes #59

ardacebi commented 6 years ago

@luceos I know that your priorities are currently not Flagrow, but this PR doesn't have any conflicts, it works like charm and it's easily mergeable.

Can you merge this so we'll also close #59?

ardacebi commented 6 years ago

Before

42243688-d3ad6f5e-7f1a-11e8-98a2-2ccb4b579874

After

screenshot_2018-08-22 forum photoshotclub 2

luceos commented 6 years ago

I personally think that using a percentage width is not the solution. Preferably this should be done using margins..

ardacebi commented 6 years ago

@luceos Okay, I'm trying now.

ardacebi commented 6 years ago

@luceos This is my best if we try fixing it with margins:

screenshot_2018-08-22 forum photoshotclub 3

.AddRecipientModal-form .RecipientsInput {
    overflow: hidden;
    height: auto;
    float: left;
    margin-left: -12px;
}
.AddRecipientModal-form .RecipientsInput-selected {
    margin: 2vh -12px;
}

If that's okay, I will change the current code on the PR to that.

ardacebi commented 6 years ago

I prefer the width solution though

luceos commented 6 years ago

Haven't looked into this yet but I dislike a float and negative margins on an input. Most likely the parent element needs a relative position to make the width 100% plus margins work properly.

luceos commented 5 years ago

this is not an issue anymore