search

FriendsOfFlarum / byobu

Well integrated, advanced private discussions for your Flarum forum.
https://discuss.flarum.org/d/4762-flagrow-by-bu-well-integrated-advanced-private-discussions
MIT License
54 stars 33 forks source link

Notifications for new PD created #80

Closed imorland closed 5 years ago

imorland commented 5 years ago

Partially addresses #75

dsevillamartin commented 5 years ago

It all looks good to me. I did notice that the forum name isn't included in the email subject. As of right now, Flarum hardcodes [<forum name>] before the email subjects, so we probably want to add it to.

Not sure if it should be in the translation or not, core doesn't do it that way, but it should be included.

imorland commented 5 years ago

@datitisev yea, I did consider the forum name in the subject, then figured that the email address field/name is almost always going to be the forum name, so didn't want to duplicate.

What are your thoughts?

dsevillamartin commented 5 years ago

@imorland well, we probably want to keep it consistent with the rest of the Flarum emails

luceos commented 5 years ago

Let's push that into a translation key, that way anyone can override it with linguist or a custom lang pack.

imorland commented 5 years ago

@datitisev @luceos

Added in translation file :)

imorland commented 5 years ago

Tiredness related git mistakes whilst squashing, please see replacement PR #81