search

FriendsOfFlarum / cookie-consent

Cookie Consent notice for your Flarum site
MIT License
6 stars 5 forks source link

Update extension to V1.0.0 #24

Closed katosdev closed 3 years ago

katosdev commented 3 years ago

Update for V1.0.0

Changes proposed in this pull request:

Reviewers should focus on:

Credits

Peace out! 👍🏻 💯

imorland commented 3 years ago

Looks like I made some boo-boos when I updated this last, can you do me a favour and update the js imports in:

https://github.com/FriendsOfFlarum/cookie-consent/blob/f7631ae24b1dc4657bd68efd87b518ef0d2c9811/js/src/forum/index.js#L1 Should be flarum/forum/app

https://github.com/FriendsOfFlarum/cookie-consent/blob/f7631ae24b1dc4657bd68efd87b518ef0d2c9811/js/src/admin/index.js#L1 Should be flarum/admin/app

https://github.com/FriendsOfFlarum/cookie-consent/blob/f7631ae24b1dc4657bd68efd87b518ef0d2c9811/js/src/admin/components/CookieConsentSettingsPage.js#L1 Should be flarum/admin/components/ExtensionPage

katosdev commented 3 years ago

Looks like I made some boo-boos when I updated this last, can you do me a favour and update the js imports in:

https://github.com/FriendsOfFlarum/cookie-consent/blob/f7631ae24b1dc4657bd68efd87b518ef0d2c9811/js/src/forum/index.js#L1

Should be flarum/forum/app https://github.com/FriendsOfFlarum/cookie-consent/blob/f7631ae24b1dc4657bd68efd87b518ef0d2c9811/js/src/admin/index.js#L1

Should be flarum/admin/app https://github.com/FriendsOfFlarum/cookie-consent/blob/f7631ae24b1dc4657bd68efd87b518ef0d2c9811/js/src/admin/components/CookieConsentSettingsPage.js#L1

Should be flarum/admin/components/ExtensionPage

Updated as requested.

katosdev commented 3 years ago

Package Lock updated.