FriendsOfFlarum / cookie-consent

Cookie Consent notice for your Flarum site
MIT License
6 stars 5 forks source link

No CSS Option as theme not adhering as expected #37

Closed DavideIadeluca closed 8 months ago

DavideIadeluca commented 1 year ago

Bug Report

Current Behavior When selecting "No CSS" as the theme in the extension setting, default CSS of the extension is still applied

Steps to Reproduce

  1. Install fof/cookie-consent v1.1.1
  2. Set "No CSS" as the theme in the extension setting
  3. View the Frontend in any browser of your choice and inspect the element
  4. Various classes already have CSS and some override css classes are added

Expected Behavior When selecting "No CSS" as the theme I expect that no CSS is loaded by the extension but the classes* still remain.

Screenshots Screenshot 2023-10-19 at 08 09 02

*from my understanding the class .cc-color-override-678040131.cc-window should not be. Screenshot 2023-10-19 at 08 10 05

Environment

Flarum core: 1.8.2
PHP version: 8.1.23
MySQL version: 10.11.4-MariaDB-1:10.11.4+maria~ubu2204
Loaded extensions: Core, date, libxml, pcre, zlib, filter, hash, json, readline, Reflection, SPL, session, ctype, curl, dom, fileinfo, gd, gmp, iconv, mbstring, openssl, pcntl, PDO, posix, standard, SimpleXML, sockets, sodium, tokenizer, xml, xmlwriter, zip, exif, mysqlnd, Phar, xmlreader, pdo_mysql, igbinary, msgpack, redis, Zend OPcache, xdebug
+--------------------------------------+---------+--------+
| Flarum Extensions                    |         |        |
+--------------------------------------+---------+--------+
| ID                                   | Version | Commit |
+--------------------------------------+---------+--------+
| flarum-flags                         | v1.8.0  |        |
| flarum-approval                      | v1.8.0  |        |
| flarum-subscriptions                 | v1.8.0  |        |
| flarum-tags                          | v1.8.0  |        |
| flarum-suspend                       | v1.8.1  |        |
| flarum-markdown                      | v1.8.0  |        |
| fof-follow-tags                      | 1.2.0   |        |
| fof-byobu                            | 1.3.2   |        |
| v17development-seo                   | v1.8.0  |        |
| fof-terms                            | 1.2.1   |        |
| fof-reactions                        | 1.2.0   |        |
| fof-links                            | 1.2.0   |        |
| fof-linguist                         | 1.1.1   |        |
| fof-cookie-consent                   | 1.1.1   |        |
| askvortsov-rich-text                 | v2.1.7  |        |
| fof-discussion-language              | 1.3.1   |        |
| flarum-sticky                        | v1.8.0  |        |
| flarum-lock                          | v1.8.0  |        |
| glowingblue-localizd                 | 1.8.1   |        |
| v17development-blog                  | v0.7.4  |        |
| fof-frontpage                        | 1.1.1   |        |
| fof-user-directory                   | 1.3.2   |        |
| glowingblue-core                     | 1.8.9   |        |
| fof-pages                            | 1.0.7   |        |
| fof-best-answer                      | 1.3.2   |        |
| flarumite-simple-discussion-views    | 1.2.1   |        |
| blomstra-horizon                     | 0.3.4   |        |
| fof-impersonate                      | 1.1.1   |        |
| glowingblue-product-picker           | 1.7.0   |        |
| fof-sitemap                          | 2.2.0   |        |
| glowingblue-user-activity            | 1.0.2   |        |
| glowingblue-solution-views           | 1.0.4   |        |
| glowingblue-redis-setup              | 1.2.1   |        |
| flarum-likes                         | v1.8.0  |        |
| flarum-lang-italian                  | 1.11.0  |        |
| flarum-lang-french                   | v4.16.0 |        |
| fof-username-request                 | 1.2.1   |        |
| fof-upload                           | 1.3.4   |        |
| fof-subscribed                       | 1.1.3   |        |
| fof-moderator-notes                  | 1.2.0   |        |
| fof-drafts                           | 1.2.2   |        |
| flarum-mentions                      | v1.8.2  |        |
| flarum-lang-english                  | v1.8.0  |        |
| extiverse-mercury                    | 0.2.0   |        |
| clarkwinkelmann-mailing              | 1.1.0   |        |
| flarum-lang-german                   | 1.8.2   |        |
| glowingblue-knwldgbs                 | 1.6.10  |        |
| glowingblue-related                  | 1.2.7   |        |
| glowingblue-gamilytics               | 1.8.10  |        |
| fof-nightmode                        | 1.5.3   |        |
| ianm-html-head                       | 1.2.2   |        |
| glowingblue-modern-theme             | 1.7.2   |        |
| blomstra-fontawesome                 | 0.1.5   |        |
| fof-spamblock                        | 1.1.0   |        |
| zerosonesfun-direct-links            | 3.1     |        |
| sycho-profile-cover                  | v1.3.5  |        |
| ianm-syndication                     | 1.3.2   |        |
| glowingblue-sunrise-it               | 1.8.0   |        |
| glowingblue-sunrise-fr               | 1.8.0   |        |
| glowingblue-sunrise-en               | 1.8.0   |        |
| glowingblue-sunrise-de               | 1.8.0   |        |
| glowingblue-sunrise                  | 1.8.11  |        |
| glowingblue-password-strength        | 3.1.0   |        |
| glowingblue-moderation               | 1.8.2   |        |
| glowingblue-datavis                  | 1.2.3   |        |
| fof-user-bio                         | 1.3.0   |        |
| fof-stopforumspam                    | 1.2.3   |        |
| fof-split                            | 1.1.0   |        |
| fof-profile-image-crop               | 1.1.6   |        |
| fof-polls                            | 2.1.1   |        |
| fof-merge-discussions                | 1.4.1   |        |
| fof-forum-statistics-widget          | 1.1.0   |        |
| fof-formatting                       | 1.0.3   |        |
| fof-disposable-emails                | 1.0.0   |        |
| fof-default-user-preferences         | 1.2.0   |        |
| fof-ban-ips                          | 1.0.3   |        |
| flarum-statistics                    | v1.8.0  |        |
| flarum-emoji                         | v1.8.0  |        |
| flarum-bbcode                        | v1.8.0  |        |
| flarum-akismet                       | v1.8.0  |        |
| clarkwinkelmann-emojionearea         | 1.0.0   |        |
| clarkwinkelmann-discussion-bookmarks | 2.0.0   |        |
| clarkwinkelmann-author-change        | 1.0.3   |        |
| blomstra-turnstile                   | 0.1.4   |        |
+--------------------------------------+---------+--------+
Base URL: http://localhost:8888
Installation path: /opt/flarum
Queue driver: redis
Session driver: redis (Code override. Configured to file)
Scheduler status: Nie ausführen
Mail driver: null
Debug mode: ON
dsevillamartin commented 12 months ago

The extension's CSS, which seems to be some version of the cookie consent styling (?), does not contain a .cc-color-override selector (or the word "override" anywhere)