FriendsOfFlarum / discussion-language

Specify the language a discussion is written in & sort by language
MIT License
6 stars 2 forks source link

Language filter breaks when navigating internal links (Toggle "Any Language" enabled) #24

Closed iamdarkle closed 2 years ago

iamdarkle commented 3 years ago

Bug Report

The new language filter via URL works really well, but some users have reported me several problems that I think are all related, it sounds to me like a SPA bug with the new filter because it always happens with all kind of internal links.

What I mean by broken is that it doesn't pass any value via URL ?language=en

Examples that cause the filter to break:

There are some other cases, but they are very similar to the first two.

Environment

iamdarkle commented 3 years ago

Important, after investigating on my side all this behaviour happens when the toggle (Show the option to select "Any Language") is enabled, if it is not enabled it works perfectly, I'll use this as a workaround :)

I got a bit confused with my user reports, I'm going to change the title to better understand the problem.

s1-ranjan commented 2 years ago

I tried to disable this plugin and re-enabling this plugin, but it does not show any option in the setting.

s1-ranjan commented 2 years ago

ISO 639-2 or ISO 639-2 are not showing in the frontend.

dsevillamartin commented 2 years ago

@s1-ranjan This seems like a separate issue? Is it related to links in the forum side?

dsevillamartin commented 2 years ago

Think this may have been fixed with some of the v1.2.x updates. Could you check again? Thanks.

iamdarkle commented 2 years ago

From what I have tried so far it seems to be fixed, thank you!