search

FriendsOfFlarum / discussion-language

Specify the language a discussion is written in & sort by language
MIT License
6 stars 2 forks source link

Discussion Language breaks `flarum/tags` feature "Hide from All Discussions" #27

Open iPurpl3x opened 2 years ago

iPurpl3x commented 2 years ago

Bug Report

Current Behavior When using Discussion Language, the "Hide from All Discussions" option of flarum/tags seems to be ignored.

Steps to Reproduce

  1. Create a tag with "Hide from All Discussions" enabled
  2. Create a discussion in this tag
  3. Navigate to "All discussions"
  4. See that the created discussion is visible in the list
  5. Disable Discussion Language
  6. See that now the discussion is hidden, as expected.

Expected Behavior "Hide from All Discussions" should work as expected.

Environment

dsevillamartin commented 2 years ago

This might be because the "All Discussions" page is not supposed to have any filters. As this extension adds a filter, it may no longer be recognized as all discussions page.

Not sure how to resolve this.

Might need specific code for tags to fix.