Preserve poll options set via FoF Polls

FriendsOfFlarum / drafts

Enables creation of discussion drafts

MIT License

16 stars 8 forks source link

Preserve poll options set via FoF Polls #22

Open pflstr opened 4 years ago

pflstr commented 4 years ago

If a discussion with a poll is saved as a draft the poll part is not saved.

askvortsov1 commented 4 years ago

For this to work:

An extra attributes column will need to be added to the database
Anything not in the defined fields (content/title/relationships) should be placed json-encoded into that extra attributes field
Everything in that extra attributes field should be made a regular attribute when drafts are loaded into frontend, and when the scheduled command runs.

askvortsov1 commented 4 years ago

Alternatively, title and content could also be moved into attributes, hence providing a unified, uniform system for saving and retreiving data. THis would probably be the most extensible option.

dsevillamartin commented 4 years ago

Don't do anything for now. I think it technically works, but I need to fix some things locally. Don't worry about it, leave it to me.

askvortsov1 commented 4 years ago

It doesn't work, I verified it. Poll is stored as an attribute (poll name, relationship to options, etc), not as a relationship.

askvortsov1 commented 4 years ago

Not doing anything now, but this might be worth straightening out before y'all tag the release

dsevillamartin commented 4 years ago

I meant that some of the code for it is there, but not handled correctly.