FriendsOfFlarum / drafts

Enables creation of discussion drafts
MIT License
16 stars 8 forks source link

Don't prompt the user to safe changes made after the last autosafe #31

Open pflstr opened 4 years ago

pflstr commented 4 years ago

If users close the composer and there are unsaved changes, they are prompted: "Discard changes to draft? In this case, wouldn't it make sense to automatically save the draft once more without asking the user?

If people are used to autosafe, they don't understand why they are sometimes asked to discard changes, and sometimes not, if by chance the last autosafe happened just before they decided to close the composer.

askvortsov1 commented 4 years ago

If I have a draft but for some reason delete everything in the content and close the composer, autosave will still keep a feasible version. I'm not sure that this would improve the UI, but I'm also not firm in that opinion

pflstr commented 4 years ago

If I have a draft but for some reason delete everything in the content and close the composer, autosave will still keep a feasible version.

Not if you are unlucky and autosave hits you just after deleting the content and just before closing the composer.

It should not be a roulette game, which version of your content is saved or if you have the opportunity to reconsider your last action. If you want to protect users from the consequences of careless deletions, you should offer to always save the last three autosafes, Flarum's version of the time machine so to speak ;)