Closed maicol07 closed 3 years ago
@clarkwinkelmann @Ralkage what do you think of the PR?
Thank you for the PR @maicol07
I feel this PR needs to be broken down a little, as there's just so much going on here.
My suggestion is to split this up into seperate PR's for the fixes, and seperately the new features.
Also, please don't commit the dist
files, these will automatically get built when we merge to master
;)
I've splitted this PR into: #43 #44 #45 #46
I'm going to close this to let you review the other ones
@imorland @davwheat @clarkwinkelmann @Ralkage
I suggest merging the PRs from the first one since newer have the changes of the previous one
Changes proposed in this pull request:
New features
feat:
:sparkles:Added selfvote option
(Defaults to false)feat:
:sparkles:Add group linking to rank
(Check details in commit)feat:
:sparkles:Added sticky group feature
feat:
:sparkles:Added option to only display the sticky rank with higher points
Fixes
fix:
:bug:Infinite loading in profile page
fix:
:bug:Deleted/Hidden post can't be expanded
fix:
:bug:No badges shown on discussions posts
(Check details in the commit)fix:
:bug:Reload page when browsing to a user profile from ranking page to avoid rendering bug
Reviewers should focus on:
All the features and fixes work well. But if you want to review something, I'll recommend checking sticky ranks
Screenshot
Confirmed
composer test
).Required changes: