Code review

[clarkwinkelmann]

Before it goes live

[luceos]

• [x] use placeholders instead of "New value" value for field names
• [ ] I'd make the frontend part closed, unless fields are required. Otherwise it's taking far too much space?
• [x] Click to edit field should not show up on the button to add new fields
• [x] Field answers in admin should have a dotted border, I thought that was the input
• [x] Admin nav icon has wrong icon.
• [ ] Speaking of icon, the package icon needs to be replaced but I haven't seen a better alternative in font awesome.

[luceos]

In https://github.com/flagrow/mason/blob/master/src/Listeners/AddApiRoutes.php

import the Controllers namespace then prefix all controllers with Controllers in the route definition. Looks much cleaner and is almost equally easy to read. Maybe put the route definitions in multiple lines instead of one.

[clarkwinkelmann]

Note to self: rename route names to use mason instead of discussion-fields

[luceos]

Going to de-assign this from me @clarkwinkelmann .

[clarkwinkelmann]

I'll close this. Everything that required immediate change has been done and it's been live for some time now.