search

FriendsOfFlarum / merge-discussions

Merge two or more discussions into one
MIT License
10 stars 7 forks source link

Merging fails when attempting to merge posts into a big discussion #11

Closed Yalfoosh closed 2 years ago

Yalfoosh commented 4 years ago

So, I'm having a problem with merging into relatively large discussions. What happens is that merging fails without a descriptive error when merging into discussions of 100 and more posts (I have yet to determine the lower bound locally). It might be only on seperated posts (unsure, have to confirm it yet), but the process I noticed the bug with is the following:

I have tried to merge the post in question with a smaller discussion and it works. I have also tried to merge discussions by making it have no tags and by making it have the same tags as the discussion I'm merging with - no difference.

I'll post an update once I determine the exact details around this locally (I posted this so I don't forget it).

dsevillamartin commented 4 years ago

Same as #5?

Yalfoosh commented 4 years ago

Same as #5?

Possible, I've reproduced it on a 29 post discussion I know there was deletion in. I might look into it, seems freaky that a global post counter system fails when there are gaps in the thread. This seems to happen even when you delete the Moderation message posts (like Merged x threads or Renamed the discussion posts), I guess?