feat: move subscription to merged discussion

FriendsOfFlarum / merge-discussions

Merge two or more discussions into one

MIT License

10 stars 7 forks source link

feat: move subscription to merged discussion #50

Closed SychO9 closed 1 year ago

SychO9 commented 1 year ago

Changes proposed in this pull request:

This PR allows moving subscriptions from merged discussions to the new final discussion, useful if someone is following discussion A but discussion A gets merged into B.

Confirmed

[x] Frontend changes: tested on a local Flarum installation.
[x] Backend changes: tests are green (run composer test).

Required changes:

[ ] Related Flarum core extension PR's: (Omit this section if irrelevant)

SychO9 commented 1 year ago

The handler is growing quite large this way. I can imagine we need to refactor this at some point. I can also imagine other extensions wanting to extend the merging logic anyway.

Agreed, after further thought, i think it'd be better to dispatch an appropriate event instead. https://github.com/FriendsOfFlarum/merge-discussions/pull/51