search

FriendsOfFlarum / nightmode

🌙 Turn off the lights!
https://discuss.flarum.org/d/21492-friendsofflarum-night-mode
MIT License
33 stars 22 forks source link

Nightmode CSS overrides Custom CSS #29

Closed phenomlab closed 4 years ago

phenomlab commented 4 years ago

In vendor > fof > nightmode > resources > less > forum > extension.less line 115 - each time I update this extension, I have to override as below

    .App:before {
        background: rgba(0,0,0,0.1);
    }

This is required to match my existing theme - otherwise, the header is loaded with a style that seems to override that which is in custom CSS. Can this be looked at also ?

BigMinnie commented 4 years ago

They put !important into the css when they would not need to, don't know why nobody updates/removes that simple thing...

dsevillamartin commented 4 years ago

The way this extension implements the dark mode isn't great. It'd be better to have two CSS files - one for dark mode, and one for light mode - but last time I checked that wasn't very easy. We do want to improve this extension.

They put !important into the css when they would not need to, don't know why nobody updates/removes that simple thing...

Where exactly are you talking about? I assume the !important used is to override the default forum scheme. I understand it's not desirable.

dsevillamartin commented 4 years ago

Fixed