Overrides not compatible with Flarum 1.2 - Githubissues

FriendsOfFlarum / nightmode

🌙 Turn off the lights!

https://discuss.flarum.org/d/21492-friendsofflarum-night-mode

MIT License

33 stars 22 forks source link

Overrides not compatible with Flarum 1.2 #56

Closed clarkwinkelmann closed 2 years ago

clarkwinkelmann commented 2 years ago

Changes in Flarum 1.2 require an update in our overrides https://github.com/FriendsOfFlarum/nightmode/tree/master/src/Overrides

I have not tested locally but I believe this is the cause of the issue discussed at https://discuss.flarum.org/d/29963-v12-bug-report

ValidateCustomLess needs to be updated for the new Less variable system https://github.com/flarum/core/blob/v1.2.0/src/Forum/ValidateCustomLess.php

Assets also has a few changes, it might be breaking the new extender https://github.com/flarum/core/blob/v1.2.0/src/Frontend/Assets.php

I think RecompileFrontendAssets is fine like it is, only a deprecation comment was added.