FriendsOfFlarum / pages

Create custom static pages in Flarum

https://discuss.flarum.org/d/18301

MIT License

23 stars 12 forks source link

Increase the maximum content length #23

Closed rafaucau closed 4 years ago

rafaucau commented 4 years ago

I changed text to mediumText so now pages can contain more content.

22

clarkwinkelmann commented 4 years ago

I don't think this is the good approach. We need a new migration that converts existing columns, so that everyone gets to the same point after updating. It would be confusing if some existing extension users still have a TEXT field in the database.

I would prefer we reach a consensus in the GitHub issue first before approving or denying any pull request.

dsevillamartin commented 4 years ago

I don't think this is the good approach. We need a new migration that converts existing columns

Is that not what this PR does? The last method is change() - doesn't that modify an existing column?

rafaucau commented 4 years ago

The last method is change() - doesn't that modify an existing column?

This modifies an existing column without losing any data in it.

clarkwinkelmann commented 4 years ago

My bad, I was certain this was a change to the first migration file for some reason :thinking:

Continue on :+1: