search

FriendsOfFlarum / pages

Create custom static pages in Flarum
https://discuss.flarum.org/d/18301
MIT License
23 stars 12 forks source link

Should the title be set as H1? #51

Closed efast1568 closed 1 year ago

efast1568 commented 1 year ago

m("h2", { className: "PageHero-title" })

Should the title be set as H1?

clarkwinkelmann commented 1 year ago

Yes, we should change it.

The reason h2 was used is most likely historical: up to Flarum 1.6, Flarum (somewhat incorrectly) used h1 for the site name, so it was not semantically correct to inject another h1 tag.

Since Flarum 1.7 this "problem" has been fixed and Flarum has updated its own h2 titles to h1. So we should do the same in this extension now.