Plugin seems to load "flatpickr.min.css" from external CDN

FriendsOfFlarum / polls

A Flarum extension that adds polls to your discussions

https://discuss.flarum.org/d/20586

MIT License

23 stars 12 forks source link

Plugin seems to load "flatpickr.min.css" from external CDN #44

Closed poVoq closed 2 years ago

poVoq commented 3 years ago

Bug Report

Current Behavior Plugin works fine but causes problems (both legal and technical) in environments that strictly prohibit loading external resources. Furthermore the CDN is hosted by Cloudflare with is a privacy concern.

As this seems to be only a small css file, would it be possible to just include it in the distribution instead of downloading it?

Thanks.

rafaucau commented 3 years ago

By the way, this extension could use the native HTML picker instead of the library.

n0099 commented 2 years ago

https://github.com/FriendsOfFlarum/polls/blob/39e2b77a2cf8b8bde51da7a1c4c44eecb5f13440/resources/less/forum.less#L1 Due to service downgrade of jsdelivr in mainland china: https://github.com/jsdelivr/jsdelivr/issues/18348#issuecomment-997777996, it's now more important to allow user self-host this css to prevent requesting it from public cdn which is currently unstable in china.

imorland commented 2 years ago

This is quite easy to solve, I'll sort this shortly...