FriendsOfFlarum / polls

A Flarum extension that adds polls to your discussions
https://discuss.flarum.org/d/20586
MIT License
24 stars 12 forks source link

Conflict with Pusher #45

Closed rafaucau closed 3 years ago

rafaucau commented 3 years ago

Bug Report

Current Behavior I noticed that after enabling this extension, discussion posts no longer update live. Errors appear in the console: Uncaught (in promise) TypeError: Cannot read property 'bind' of undefined at addPollToDiscussion.js:46

Steps to Reproduce

  1. Enable fof/polls
  2. Enable and configure flarum/pusher
  3. Go to discussion
  4. See errors in the console

Expected Behavior Discussion posts should update live when fof/polls is enabled and there should be no console errors

Screenshots image

Environment

Output of "php flarum info" ``` Flarum core 1.0.2 PHP version: 8.0.3-dh2 Loaded extensions: Core, date, libxml, openssl, pcre, sqlite3, zlib, bcmath, bz2, calendar, ctype, curl, dom, hash, fileinfo, filter, ftp, gd, gettext, gmp, SPL, iconv, session, intl, json, ldap, mbstring, standard, odbc, PDO, mysqlnd, PDO_ODBC, pdo_pgsql, pdo_sqlite, pgsql, Phar, posix, Reflection, imap, shmop, SimpleXML, snmp, soap, sockets, pdo_mysql, exif, sysvmsg, tokenizer, xml, xmlreader, xmlwriter, xsl, zip, mysqli, apcu, dba, imagick, memcached, redis, yaml, Zend OPcache +-----------------------------------+--------------+--------+ | Flarum Extensions | | | +-----------------------------------+--------------+--------+ | ID | Version | Commit | +-----------------------------------+--------------+--------+ | flarum-flags | v1.0.0 | | | flarum-approval | v1.0.0 | | | flarum-tags | v1.0.3 | | | flarum-suspend | v1.0.0 | | | fof-byobu | 1.0.0-beta.6 | | | flarum-subscriptions | v1.0.0 | | | aberit-communities | dev-master | | | fof-follow-tags | 1.0.0 | | | flarum-markdown | v1.0.1 | | | aberit-gamification | dev-master | | | fof-nightmode | 1.0.0 | | | fof-user-directory | 1.0.1 | | | flarumite-simple-discussion-views | 1.0.1 | | | flarum-pusher | v1.0.0 | | | fof-polls | 1.0.1 | | | extiverse-mercury | 0.1.2 | | | askvortsov-pwa | v3.0.3 | | | fof-masquerade | 1.0.0 | | | aberit-follow-communities | dev-master | | | flarum-bbcode | v1.0.0 | | | fof-pages | 1.0.1 | | | fof-split | 1.0.0 | | | fof-oauth | 1.0.0 | | | ianm-diff | 3.0.0 | | | fof-best-answer | 1.0.1 | | | fof-user-bio | 1.0.0 | | | flarum-mentions | v1.0.0 | | | rob006-lang-polish | v0.5.1 | | | v17development-seo | v1.8.0 | | | clarkwinkelmann-author-change | 1.0.1 | | | askvortsov-rich-text | v2.0.3 | | | flarum-statistics | v1.0.0 | | | fof-formatting | 1.0.0 | | | flarum-lock | v1.0.0 | | | fof-upload | 1.0.1 | | | flarum-emoji | v1.0.0 | | | fof-spamblock | 1.0.0 | | | fof-socialprofile | 1.0.0 | | | aberit-forum | dev-master | | | fof-merge-discussions | 1.0.0 | | | aberit-moderation-tools | dev-master | | +-----------------------------------+--------------+--------+ ```
dsevillamartin commented 3 years ago

Fixed with 0391c1d0e3811ac2c240f5c43fe9d79533888ddd in v1.0.2.