search

FriendsOfFlarum / realtimedate

Makes the human time (ex. 2 minutes ago) update in real time.
MIT License
2 stars 1 forks source link

Reactions and upvotes mess up the timer #2

Open ghost opened 4 years ago

ghost commented 4 years ago

Bug description

Adding a reaction to a post, upvote/downvote or a like temporaly close to the next date update will duplicate the date display:

image

This stays like this until the next date refresh. I wasn't sure where to report this as it looked like a Gamification or Reactions bug, but after seeing the behaviour reproduced in my almost vanilla local beta12 Flarum, I decided to report it as a realtimedate bug.

Supposed behaviour

Reacting, upvoting/downvoting or liking a post temporaly close to the next date update doesn't mess up the date display.

Flarum detail

This was first seen on a live beta12 Flarum with PHP 7.4.4 and nginx. The issue was reproduced with only Gamification, Reactions, Likes and realtimedate activated (aside from the usual bundled extensions) on a local server of the same specifications.

Additional details

This bug is not critical by any means because it persists only until the next date update, and is easy to reproduce only when trying to react, vote or like as the 11-59 seconds ago is displayed (because you get a chance every second). Perhaps it's concurrency related?

dsevillamartin commented 4 years ago

If I remember correctly, this is an issue with core itself. See https://github.com/flarum/core/issues/1087. I don't think this can be fixed anywhere else. There may be JS errors in the console.