FriendsOfFlarum / secure-https

Changes all images using HTTP to HTTPS
https://discuss.flarum.org/d/17771
MIT License
6 stars 7 forks source link

UrlGenerator is resolved too early, breaking other extensions #7

Closed clarkwinkelmann closed 3 years ago

clarkwinkelmann commented 3 years ago

https://github.com/FriendsOfFlarum/secure-https/blob/9b0734a41d06a314c5c59f40f6a2048473a90900/src/Listeners/ModifyContentHtml.php#L35

In the ModifyContentHtml subscriber, UrlGenerator is resolved during the extension booting sequence, preventing any more extension from registering routes. This means all routes defined by extensions enabled after secure-https will return 404 errors.