Use uid instead of username

FriendsOfFlarum / sitemap

Generate a sitemap.

https://discuss.flarum.org/d/14941

MIT License

14 stars 16 forks source link

Use uid instead of username #10

Closed wloot closed 4 years ago

wloot commented 4 years ago

Avoid 404 return when requesting a purely digital username
Keep url after changing username, more search engine friendly

clarkwinkelmann commented 4 years ago

There's a good chance Flarum will stop supporting accessing user profiles by ID once https://github.com/flarum/core/issues/1356 is fixed.

This was never an official feature, just a quirk because the same API endpoint is currently used for API usage and frontend.

As such I would recommend against the proposed approach here. Usernames are the official canonical URL to user profiles.

wloot commented 4 years ago

There's a good chance Flarum will stop supporting accessing user profiles by ID once flarum/core#1356 is fixed.

This was never an official feature, just a quirk because the same API endpoint is currently used for API usage and frontend.

As such I would recommend against the proposed approach here. Usernames are the official canonical URL to user profiles.

Okay, I got it now.

clarkwinkelmann commented 4 years ago

I'm going to close this. Thanks for taking the time to submit a PR even we don't use it!