Closed iPurpl3x closed 1 year ago
@clarkwinkelmann or @davwheat, would one of you have time to look at this and potentially release it? I had conceptually discussed these changes previously with @imorland, and he supported the main idea of this new pseudo resource for static URLs.
@imorland I added some documentation to the readme.
Changes proposed in this pull request: In this PR there is a new default Resource added to the Provider:
StaticUrls
. This is a pseudo-resource, as it isn't related to any model. It contains a list of route names that can be iterated to generate URLs to static pages of the app. By default there are 2 static pages: index and tags. Tags are only present in the list if the tags extension is activated.A new Extender (
FoF\Sitemap\Extend\RegisterStaticUrl
) has been added, so that other extensions can add thier own static URLs to the list. Example:Other minor changes:
require-dev
so that type-hinting works properlyReviewers should focus on:
RegisterStaticUrl
works as expectedScreenshot
Confirmed
composer test
).