search

FriendsOfFlarum / socialprofile

Add custom social media pages to your user profile
MIT License
13 stars 8 forks source link

Added Email and Mastodon icons. #1

Closed JoshStrobl closed 4 years ago

JoshStrobl commented 5 years ago

This PR adds the FontAwesome Mastodon icon as an option, for those which have an account on a Mastodon server. Additionally it adds an email icon as per this downstream request.

dsevillamartin commented 5 years ago

The issue with the email one is that the value/url would have to be mailto:? for the email to properly work for sending... and that's not really social. I'm not sure if I want to include it or not...

Mastodon is fine with me.

JoshStrobl commented 5 years ago

Yes, a mailto:user@domain.tld would with most systems opens up an email client, e.g. Thunderbird.

properly work for sending... and that's not really social

That's fair, but one could argue that the following aren't exactly "social" either:

If we're viewing social as "this platform or service enables one or more individuals to communicate", then email falls into that as well.

dsevillamartin commented 5 years ago

@JoshStrobl Hm, true, but the fact that adding mailto: is needed will most likely bring a bunch of complains from users.