FriendsOfFlarum / socialprofile

Add custom social media pages to your user profile
MIT License
13 stars 7 forks source link

Typo in admin initializer name #34

Open clarkwinkelmann opened 2 years ago

clarkwinkelmann commented 2 years ago

The initializer name of the extension in the admin frontend is incorrectly spelled and doesn't match with the extension ID

actual fof-socialprfile expected fof-socialprofile

https://github.com/FriendsOfFlarum/socialprofile/blob/cf7a4e996418a9306c0c806f0ea806c37e97cbad/js/src/admin/index.ts#L3

This is not causing any issue. But fixing it might, as it would be a breaking change if any other extension relies on the current name.

I suggest we leave it as-it for now, but if there's ever a major update of our extension, try to fix it at the same time.

The initializer in the forum frontend is spelled as expected and doesn't need changing.