Hopefully fix ext not working (assuming subfolder setup) + some cleanup

FriendsOfFlarum / stopforumspam

Run registrations through the Stop Forum Spam database

MIT License

9 stars 6 forks source link

Hopefully fix ext not working (assuming subfolder setup) + some cleanup #18

Closed dsevillamartin closed 2 years ago

dsevillamartin commented 2 years ago

Fixes hopefully #17

Changes proposed in this pull request:

I'm assuming the ext did not work with subfolders due to the register path check
- Please check whether it did/didn't work, and whether this PR fixes it if necessary
JS cleanup
- Use Flarum prettier
- Add Flarum tsconfig
- Update to Webpack 5

Reviewers should focus on:

Mainly the register path thing on subfolder setups

Confirmed

[X] Frontend changes: tested on a local Flarum installation.
[ ] Backend changes: tests are green (run composer test).

ekumanov commented 2 years ago

Is there a way I can test this merge request on my forum before it is merged?

dsevillamartin commented 2 years ago

@ekumanov Yep! You can run composer require fof/stopforumspam:dev-ds/fixes-cleanup.

ekumanov commented 2 years ago

@datitisev thanks, just tested it and can confirm it finally works now, thank you! When you release it, how should I switch to the released version (from the dev branch, although they will be the same as content)?

dsevillamartin commented 2 years ago

@ekumanov Looks like composer require fof/stopforumspam will upgrade from dev to stable. So you can run that when it's released - I'll ping you and let you know 🙂.